Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to KDBush v4 & Supercluster v8 for better performance #12682

Merged
merged 2 commits into from
Apr 27, 2023

Conversation

mourner
Copy link
Member

@mourner mourner commented Apr 27, 2023

Launch Checklist

  • briefly describe the changes in this PR
  • write tests for all new functionality
  • post benchmark scores (pending benchmap-js run)
  • manually test the debug page
  • apply changelog label ('bug', 'feature', 'docs', etc) or use the label 'skip changelog'
  • add an entry inside this element for inclusion in the mapbox-gl-js changelog: <changelog>Improve performance of clustered sources: 20% faster loading & 40–60% less memory overhead. Improve performance of symbol collisions.</changelog>

@mourner mourner added the performance ⚡ Speed, stability, CPU usage, memory usage, or power usage label Apr 27, 2023
@mourner mourner requested a review from a team as a code owner April 27, 2023 09:44
Copy link

@prisma-cloud-devsecops prisma-cloud-devsecops bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prisma Cloud has found errors in this PR ⬇️

version "3.0.0"
resolved "https://registry.yarnpkg.com/kdbush/-/kdbush-3.0.0.tgz#f8484794d47004cc2d85ed3a79353dbe0abc2bf0"
integrity sha512-hRkd6/XW4HTsA9vjVpY9tuXJYLSlelnkTmVFu4M9/7MIYQtFcHpbugAU7UbOfjOiVSVYl2fqgBuJ32JUmRo5Ew==
kdbush@^4.0.1:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yaml 2.1.1 / yarn.lock

Total vulnerabilities: 1

Critical: 0 High: 0 Medium: 1 Low: 0
Vulnerability IDSeverityCVSSFixed inStatus
CVE-2023-2251 MEDIUM MEDIUM 4 2.2.2 Open

yarn.lock Show resolved Hide resolved
version "3.0.0"
resolved "https://registry.yarnpkg.com/kdbush/-/kdbush-3.0.0.tgz#f8484794d47004cc2d85ed3a79353dbe0abc2bf0"
integrity sha512-hRkd6/XW4HTsA9vjVpY9tuXJYLSlelnkTmVFu4M9/7MIYQtFcHpbugAU7UbOfjOiVSVYl2fqgBuJ32JUmRo5Ew==
kdbush@^4.0.1:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spdx-license-ids 3.0.12 / yarn.lock

MEDIUM  Noncompliant License (CC0-1.0)

This package contains a license that is not OSI-approved.

version "3.0.0"
resolved "https://registry.yarnpkg.com/kdbush/-/kdbush-3.0.0.tgz#f8484794d47004cc2d85ed3a79353dbe0abc2bf0"
integrity sha512-hRkd6/XW4HTsA9vjVpY9tuXJYLSlelnkTmVFu4M9/7MIYQtFcHpbugAU7UbOfjOiVSVYl2fqgBuJ32JUmRo5Ew==
kdbush@^4.0.1:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spdx-exceptions 2.3.0 / yarn.lock

MEDIUM  Noncompliant License (CC-BY-3.0)

This package contains a license that is not OSI-approved.

version "3.0.0"
resolved "https://registry.yarnpkg.com/kdbush/-/kdbush-3.0.0.tgz#f8484794d47004cc2d85ed3a79353dbe0abc2bf0"
integrity sha512-hRkd6/XW4HTsA9vjVpY9tuXJYLSlelnkTmVFu4M9/7MIYQtFcHpbugAU7UbOfjOiVSVYl2fqgBuJ32JUmRo5Ew==
kdbush@^4.0.1:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

path-scurry 1.7.0 / yarn.lock

MEDIUM  Noncompliant License (BlueOak-1.0.0)

This package contains a license that is not OSI-approved.

version "3.0.0"
resolved "https://registry.yarnpkg.com/kdbush/-/kdbush-3.0.0.tgz#f8484794d47004cc2d85ed3a79353dbe0abc2bf0"
integrity sha512-hRkd6/XW4HTsA9vjVpY9tuXJYLSlelnkTmVFu4M9/7MIYQtFcHpbugAU7UbOfjOiVSVYl2fqgBuJ32JUmRo5Ew==
kdbush@^4.0.1:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

type-fest 0.18.1 / yarn.lock

MEDIUM  Noncompliant License (CC0-1.0)

This package contains a license that is not OSI-approved.

version "3.0.0"
resolved "https://registry.yarnpkg.com/kdbush/-/kdbush-3.0.0.tgz#f8484794d47004cc2d85ed3a79353dbe0abc2bf0"
integrity sha512-hRkd6/XW4HTsA9vjVpY9tuXJYLSlelnkTmVFu4M9/7MIYQtFcHpbugAU7UbOfjOiVSVYl2fqgBuJ32JUmRo5Ew==
kdbush@^4.0.1:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

type-fest 0.12.0 / yarn.lock

MEDIUM  Noncompliant License (CC0-1.0)

This package contains a license that is not OSI-approved.

version "3.0.0"
resolved "https://registry.yarnpkg.com/kdbush/-/kdbush-3.0.0.tgz#f8484794d47004cc2d85ed3a79353dbe0abc2bf0"
integrity sha512-hRkd6/XW4HTsA9vjVpY9tuXJYLSlelnkTmVFu4M9/7MIYQtFcHpbugAU7UbOfjOiVSVYl2fqgBuJ32JUmRo5Ew==
kdbush@^4.0.1:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jackspeak 2.1.0 / yarn.lock

MEDIUM  Noncompliant License (BlueOak-1.0.0)

This package contains a license that is not OSI-approved.

version "3.0.0"
resolved "https://registry.yarnpkg.com/kdbush/-/kdbush-3.0.0.tgz#f8484794d47004cc2d85ed3a79353dbe0abc2bf0"
integrity sha512-hRkd6/XW4HTsA9vjVpY9tuXJYLSlelnkTmVFu4M9/7MIYQtFcHpbugAU7UbOfjOiVSVYl2fqgBuJ32JUmRo5Ew==
kdbush@^4.0.1:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

expand-template 2.0.3 / yarn.lock

MEDIUM  Noncompliant License (WTFPL)

This package contains a license that is not OSI-approved.

version "3.0.0"
resolved "https://registry.yarnpkg.com/kdbush/-/kdbush-3.0.0.tgz#f8484794d47004cc2d85ed3a79353dbe0abc2bf0"
integrity sha512-hRkd6/XW4HTsA9vjVpY9tuXJYLSlelnkTmVFu4M9/7MIYQtFcHpbugAU7UbOfjOiVSVYl2fqgBuJ32JUmRo5Ew==
kdbush@^4.0.1:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@csstools/selector-specificity 2.0.2 / yarn.lock

MEDIUM  Noncompliant License (CC0-1.0)

This package contains a license that is not OSI-approved.

Copy link
Contributor

@stepankuzmin stepankuzmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mourner mourner merged commit 29588a7 into main Apr 27, 2023
10 checks passed
@mourner mourner deleted the faster-cross-tile-index branch April 27, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance ⚡ Speed, stability, CPU usage, memory usage, or power usage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants