-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use WebGL2 in render tests by default #12701
Conversation
The heatmap failures look not just like platform differences but more like the difference between the full and no-half-float fallback paths — since there are expected pics for both in that particular test, worth investigating what's happening there before we up the allowed diff. |
@mourner It appears that the Firefox with WebGL2 disabledFirefox with WebGL2 enabled |
@stepankuzmin this looks like a genuine bug — FF/WebGL2 renders heatmaps with low res (see some pixel artifacts) as if it bypasses the half-float code path. We can merge the PR anyway but we should make sure to bring those allowed values back after fixing the root cause. |
. |
We do this, and spec wise, it looks correct:
EXT_color_buffer_half_float was originally WebGL1 extension and relatively recently applied as WebGL2 extension (2020) KhronosGroup/WebGL#3146. I didn't do a thorough check (https://hg.mozilla.org/mozilla-central/log?rev=EXT_color_buffer_half_float)- it is worth checking if it is implemented as WebGL 2 extension in Firefox and report an issue there. It was removed in https://bugzilla.mozilla.org/show_bug.cgi?id=1271830 but didn't see a PR that's adding it back to WebGL 2 extension list |
It looks like the latest Firefox misses the |
@mourner @astojilj I've filled a bug in the Firefox tracker for that https://bugzilla.mozilla.org/show_bug.cgi?id=1832535 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, but let's create an issue to make sure to follow up on FF heatmaps & the allowed diff.
This reverts commit e078bf1.
Switches render tests to use WebGL2 by default. Adds WebGL1 render tests for:
Also, increases the
allowed
value for the heatmap render tests, which were failing in Firefox.Note: sometimes,
test-render-mac-safari-dev
(WebGL2) fails withLaunch Checklist
mapbox-gl-js
changelog:<changelog></changelog>