Add clearer error message for map.queryRenderedFeatures... #3196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mourner
requested changes
Sep 16, 2016
| @@ -115,6 +115,7 @@ | |||
| }); | |||
|
|
|||
| map.on('click', function(e) { | |||
| var features = map.queryRenderedFeatures(e.point, {layers:['derp']}); | |||
There was a problem hiding this comment.
Not necessary for this debug page.
| if (!(this._layers[layerId] instanceof StyleLayer)) { | ||
| // this layer is not in the style.layers array | ||
| return this.fire('error', {error: 'The layer \'' + layerId + '\' does not exist in the map\'s style and cannot be queried for features.'}); | ||
| } | ||
| includedSources[this._layers[layerId].source] = true; |
There was a problem hiding this comment.
You could remove some repetition here by doing:
var layer = this._layers[params.layers[i]];
...
layer.id| t.test('fires an error if layer included in params does not exist on the style', function(t) { | ||
| var errors = 0; | ||
| sinon.stub(style, 'fire', function() { | ||
| if (arguments[1].error && arguments[1].error.includes('does not exist in the map\'s style and cannot be queried for features.')) errors++; |
There was a problem hiding this comment.
I think it's cleaner to use usual function parameters rather than arguments.
mollymerp
force-pushed
the
qrf-error-layer
branch
from
8045a5a
to
983feb7
Compare
mollymerp
force-pushed
the
qrf-error-layer
branch
from
983feb7
to
20ff98d
Compare
|
fixed @mourner ! |
mourner
approved these changes
Sep 16, 2016
| var layer = this._layers[params.layers[i]]; | ||
| if (!(layer instanceof StyleLayer)) { | ||
| // this layer is not in the style.layers array | ||
| return this.fire('error', {error: 'The layer \'' + params.layers[i] + '\' does not exist in the map\'s style and cannot be queried for features.'}); |
There was a problem hiding this comment.
This line is a bit too long, can we make it two lines?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when called with a layer that does not exist in the map's style.
#3084
Launch Checklist