Create single source of truth for plugin versions #3300
Conversation
|
Awesome stuff!
|
|
@mollymerp has graciously agreed to expand the scope of this PR to include #3076 🙌 |
|
Updated to cover #3076 as well -- once this 🚢 we should be able to delete that repo. |
| @@ -104,6 +104,8 @@ | |||
| "start-docs": "npm run build-min && npm run build-docs && jekyll serve --watch", | |||
| "lint": "eslint --ignore-path .gitignore js test bench docs/_posts/examples/*.html", | |||
| "open-changed-examples": "git diff --name-only mb-pages HEAD -- docs/_posts/examples/*.html | awk '{print \"http://127.0.0.1:4000/mapbox-gl-js/example/\" substr($0,33,length($0)-37)}' | xargs open", | |||
| "plugin-test":"tap plugins/test", | |||
There was a problem hiding this comment.
We should keep all our tests within test. How about test/plugins?
| @@ -104,6 +104,8 @@ | |||
| "start-docs": "npm run build-min && npm run build-docs && jekyll serve --watch", | |||
| "lint": "eslint --ignore-path .gitignore js test bench docs/_posts/examples/*.html", | |||
| "open-changed-examples": "git diff --name-only mb-pages HEAD -- docs/_posts/examples/*.html | awk '{print \"http://127.0.0.1:4000/mapbox-gl-js/example/\" substr($0,33,length($0)-37)}' | xargs open", | |||
| "plugin-test":"tap plugins/test", | |||
There was a problem hiding this comment.
When will these tests get run? If they're quick, we could run them whenever npm test is called.
| @@ -8,6 +8,8 @@ | |||
| - isc | |||
| code: https://github.com/mapbox/mapbox-gl-compare | |||
| license: ISC | |||
| suffix: compare | |||
| css: true | |||
| js: true | |||
There was a problem hiding this comment.
We may need to go back to the explicit markup if we hever have a 3rd party plugin that:
- requires extra boilerplate
- is hosted in a different way
- uses a different naming convention
There was a problem hiding this comment.
Would we want to host 3rd party plugins on the mapbox cdn? I assumed that we would only host plugins that are created in-house but yeah we can always modify the markup in the future.
There was a problem hiding this comment.
We might. And we might want to document plugins that are hosted other places.
|
Is it absolutely necessary to include all plugin versions with their assets in the gl-js repository? It doesn't feel quite right to me... Could we e.g. mirror http://unpkg.com/ CDN plugin links instead? |
|
It is not necessary for us to include all plugin versions & assets in the gl-js repository. Doing so was the simplest way to merge the GL JS and GL Plugins repositories. I'd be excited about follow-up issues / PRs that move us towards a more elegant system. |
Now, whenever a new version of a plugin in https://github.com/mapbox/mapbox-gl-plugins is released, we will only need to update the version in
/docs/_data/plugins.jsonto change the URL version on both the plugins page and the examples page.cc @ghoshkaj @mcwhittemore @tristen @lucaswoj
Launch Checklist