enable eslint on marker class #3831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mourner
requested changes
Dec 19, 2016
| // because rouding the coordinates at every `move` event causes stuttered zooming | ||
| // we only round them when _update is called with `moveend` or when its called with | ||
| // no arguments (when the Marker is initialized or Marker#setLngLat is invoked). | ||
| if (!e || e.type === "moveend") pos = pos.round(); | ||
| DOM.setTransform(this._element, 'translate(' + pos.x + 'px,' + pos.y + 'px)'); | ||
| DOM.setTransform(this._element, `translate(' + ${pos.x} + 'px,' + ${pos.y} + 'px)`); |
There was a problem hiding this comment.
This doesn't look right. You probably want translate(${pos.x}px, ...
mourner
approved these changes
Dec 19, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eslint was disabled which resulted in #3830 not being caught by the test. this re-enables and makes the necessary syntax changes.
Launch Checklist
cc @mourner