New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for webgl-based canvas sources rendering flipped in 0.40.0 + non-animated optimization #5303

Merged
merged 4 commits into from Sep 18, 2017

Conversation

Projects
None yet
3 participants
@lbud
Contributor

lbud commented Sep 14, 2017

WebGL APIs and Canvas APIs are vertically flipped (gl reads from the lower left, canvas from the upper left), so I introduced #5300 in #5155. Eventually we should try to write render tests with a secondary webgl canvas 馃 to catch bugs like this, but in the meantime this should make it into the 0.40.1 patch release.

Edit: this PR also modifies the intermediary read step to only reread if a canvas is supposed to be animated, if it hasn't been read yet, or if it is resized, to mitigate performance concerns for non-animated canvases (see #5301).

Fixes #5300.
Refs #5301.

Launch Checklist

  • briefly describe the changes in this PR
  • manually test the debug page

@lbud lbud changed the title from Flip webgl-based canvas pixels before copying them to intermediary bu鈥 to Fix for webgl-based canvas sources rendering flipped in 0.40.0 Sep 14, 2017

Show outdated Hide outdated src/source/canvas_source.js Outdated

@lbud lbud changed the title from Fix for webgl-based canvas sources rendering flipped in 0.40.0 to Fix for webgl-based canvas sources rendering flipped in 0.40.0 + non-animated optimization Sep 15, 2017

@lbud lbud changed the title from Fix for webgl-based canvas sources rendering flipped in 0.40.0 + non-animated optimization to [not ready] Fix for webgl-based canvas sources rendering flipped in 0.40.0 + non-animated optimization Sep 15, 2017

@lbud lbud changed the title from [not ready] Fix for webgl-based canvas sources rendering flipped in 0.40.0 + non-animated optimization to Fix for webgl-based canvas sources rendering flipped in 0.40.0 + non-animated optimization Sep 15, 2017

Show outdated Hide outdated src/source/canvas_source.js Outdated

@lbud lbud merged commit 0601904 into master Sep 18, 2017

1 check passed

ci/circleci: build Your tests passed on CircleCI!
Details

@lbud lbud deleted the 5300-canvas-flip branch Sep 18, 2017

@gpbmike gpbmike referenced this pull request Oct 11, 2017

Closed

Canvas Source Performance Increase #5448

3 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment