Ensure drag handlers request render frames on move #6068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #6063 Caused by #6005 because, after that change, the drag handlers relied on the `move` event to trigger a map rerender to pick up the next batch of mouse movements. This worked fine while dragging was in progress, but after the user paused and the render frame triggered by the last `move` event was complete, there was nothing to re-initiate the render loop once the mouse moved again.
mollymerp
approved these changes
Jan 26, 2018
mollymerp
reviewed
Jan 26, 2018
| // https://github.com/mapbox/mapbox-gl-js/issues/6063 | ||
| update.reset(); | ||
| simulate.mousemove(map.getCanvas(), {bubbles: true, buttons: 2}); | ||
| t.equal(update.callCount, 1); |
There was a problem hiding this comment.
can do t.ok(update.calledOnce()) as well but this works too!
There was a problem hiding this comment.
I like t.equal(update.callCount, 1) because if it fails, you see the actual/incorrect value in the test log
|
Sorry if it's a stupid question, but I wonder why it has been merged into |
|
We're using |
anandthakker
added a commit
that referenced
this pull request
Jan 29, 2018
Closes #6063 Caused by #6005 because, after that change, the drag handlers relied on the `move` event to trigger a map rerender to pick up the next batch of mouse movements. This worked fine while dragging was in progress, but after the user paused and the render frame triggered by the last `move` event was complete, there was nothing to re-initiate the render loop once the mouse moved again.
pathmapper
pushed a commit
to pathmapper/mapbox-gl-js
that referenced
this pull request
Feb 13, 2018
…box#6073) Closes mapbox#6063 Caused by mapbox#6005 because, after that change, the drag handlers relied on the `move` event to trigger a map rerender to pick up the next batch of mouse movements. This worked fine while dragging was in progress, but after the user paused and the render frame triggered by the last `move` event was complete, there was nothing to re-initiate the render loop once the mouse moved again.
pathmapper
pushed a commit
to pathmapper/mapbox-gl-js
that referenced
this pull request
Feb 13, 2018
…box#6073) Closes mapbox#6063 Caused by mapbox#6005 because, after that change, the drag handlers relied on the `move` event to trigger a map rerender to pick up the next batch of mouse movements. This worked fine while dragging was in progress, but after the user paused and the render frame triggered by the last `move` event was complete, there was nothing to re-initiate the render loop once the mouse moved again.
This was referenced Feb 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6063
Caused by #6005 because, after that change, the drag handlers relied on the
moveevent to trigger a map rerender to pick up the next batch of mouse movements.This worked fine while dragging was in progress, but after the user paused and the render frame triggered by the last
moveevent was complete, there was nothing to re-initiate the render loop once the mouse moved again.Launch Checklist