Evaluate feature-state dependent layer IDs on bucket creation #7790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 18, 2019 14:17
asheemmamoowala
force-pushed
the
fix-7523
branch
from
36270d8
to
826e5c1
Compare
5 tasks
mourner
approved these changes
Jan 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7523.
Alternative solution to #7615.
This fix tries to address a hard to reproduce race condition where the
StyleLayer#isStateDependent()method is called before the paint property expressions are available. Ideally, this method would not be called until the layer has been deserialized full from the worker.The solution proposed here is to move the computation of
isStateDependentto the workers during bucket creation. Paint property expressions are expected to be available during this operation. This has the added benefit of removing an extra parse and evaluation of the expressions on the main thread.cc @mourner