Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

Deprecate MapboxMap#cycleDebugOptions #104

Merged
merged 1 commit into from
Dec 17, 2019
Merged

Deprecate MapboxMap#cycleDebugOptions #104

merged 1 commit into from
Dec 17, 2019

Conversation

LukasPaczos
Copy link
Member

Closes #103. Requires a backport.

@LukasPaczos LukasPaczos added this to the release-tequila milestone Dec 16, 2019
@LukasPaczos LukasPaczos changed the title Deprecate MapboxMap#cycleDebugActive Deprecate MapboxMap#cycleDebugOptions Dec 16, 2019
tobrun
tobrun reviewed Dec 17, 2019
View reviewed changes
Copy link
Member

@tobrun tobrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 on deprecation but atm you can only toggle debug on and off and not enable any of the debug options. I think we would need to expose DebugOptions to not regress functionality.

@LukasPaczos
Copy link
Member Author

Sounds good. Can we merge this one to make the branch stable in the meantime?

@LukasPaczos LukasPaczos merged commit c4782e7 into master Dec 17, 2019
@LukasPaczos LukasPaczos deleted the lp-debug-options-103 branch December 17, 2019 13:05
@LukasPaczos LukasPaczos mentioned this pull request Dec 17, 2019
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tobrun tobrun tobrun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
release-tequila
Development

Successfully merging this pull request may close these issues.

UnsatisfiedLinkError on debug mode change
2 participants
@LukasPaczos @tobrun