AccountManager: write user ID synchronously, keep it in memory. #145

tarigo · 2020-01-14T15:32:56Z

write user ID synchronously in order to avoid potential side effects (use commit() instead of apply());
cache userId (as class member); if it fails to save shared preferences (insufficient storage error or whatever), at least we have app life-time user ID;
getSkuToken() is used from different thread (by http stack), so lets move all interaction with user id property to synchronized method;

langsmith

🚢

* AccountManager: write user ID synchronously, keep it in memory. * Unit tests: run AccountsManagerTest with Robolectric.

AccountManager: write user ID synchronously, keep it in memory.

c76e7e1

tarigo requested a review from tobrun January 14, 2020 15:32

tarigo self-assigned this Jan 14, 2020

tobrun requested review from langsmith and zugaldia January 14, 2020 15:35

Unit tests: run AccountsManagerTest with Robolectric.

dfdff33

tarigo marked this pull request as ready for review January 14, 2020 18:34

langsmith approved these changes Jan 15, 2020

View reviewed changes

tobrun approved these changes Jan 15, 2020

View reviewed changes

tarigo merged commit ef4c225 into master Jan 15, 2020

tobrun pushed a commit that referenced this pull request Jan 22, 2020

AccountManager: write user ID synchronously, keep it in memory. (#145)

02e525a

* AccountManager: write user ID synchronously, keep it in memory. * Unit tests: run AccountsManagerTest with Robolectric.

tobrun pushed a commit that referenced this pull request Jan 22, 2020

AccountManager: write user ID synchronously, keep it in memory. (#145)

350ad46

* AccountManager: write user ID synchronously, keep it in memory. * Unit tests: run AccountsManagerTest with Robolectric.

tobrun pushed a commit that referenced this pull request Jan 22, 2020

AccountManager: write user ID synchronously, keep it in memory. (#145)

54d11f5

* AccountManager: write user ID synchronously, keep it in memory. * Unit tests: run AccountsManagerTest with Robolectric.

zugaldia mentioned this pull request Jan 24, 2020

IllegalStateException: MapboxNavigationAccounts: skuToken cannot be null or empty mapbox/mapbox-navigation-android#2424

Closed

tarigo deleted the tarigo_sku_user_id_fix branch March 25, 2020 13:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

AccountManager: write user ID synchronously, keep it in memory. #145

AccountManager: write user ID synchronously, keep it in memory. #145

tarigo commented Jan 14, 2020 •

edited

Loading

langsmith left a comment

AccountManager: write user ID synchronously, keep it in memory. #145

AccountManager: write user ID synchronously, keep it in memory. #145

Conversation

tarigo commented Jan 14, 2020 • edited Loading

langsmith left a comment

Choose a reason for hiding this comment

tarigo commented Jan 14, 2020 •

edited

Loading