Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

Add telemetry events classes to proguard #195

Merged
merged 1 commit into from Feb 28, 2020
Merged

Add telemetry events classes to proguard #195

merged 1 commit into from Feb 28, 2020

Conversation

Chaoba
Copy link
Contributor

@Chaoba Chaoba commented Feb 25, 2020

Resolves #194

@Chaoba Chaoba requested a review from tobrun February 25, 2020 06:14
tobrun
tobrun reviewed Feb 25, 2020
View reviewed changes
Copy link
Member

@tobrun tobrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add proguard mapping file? or some output to validate if this change works? I like the approach of using SerializedName to have granular control, we mostly have fixed this type of issues with a proguard configuration..

@Chaoba Chaoba self-assigned this Feb 26, 2020
@Chaoba Chaoba changed the title Add '@SerializedName' for member variables in Event classes. Add telemetry events classes to proguard Feb 27, 2020
@Chaoba Chaoba merged commit 81189a9 into master Feb 28, 2020
@Chaoba Chaoba deleted the kl-event-obfuscation branch February 28, 2020 02:05
@tobrun tobrun mentioned this pull request Mar 2, 2020
Closed
2 tasks
@chloekraw chloekraw mentioned this pull request Mar 5, 2020
Merged
@Guardiola31337 Guardiola31337 mentioned this pull request Mar 14, 2020
Merged
12 tasks
@Guardiola31337 Guardiola31337 mentioned this pull request Apr 1, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tobrun tobrun tobrun approved these changes

Assignees

@Chaoba Chaoba

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Telemetry events class obfuscation
2 participants
@Chaoba @tobrun