Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

Add min and max pitch options #199

Merged
merged 3 commits into from Feb 28, 2020
Merged

Add min and max pitch options #199

merged 3 commits into from Feb 28, 2020

Conversation

Chaoba
Copy link
Contributor

@Chaoba Chaoba commented Feb 26, 2020

Resolves #192

@Chaoba Chaoba self-assigned this Feb 26, 2020
@Chaoba Chaoba requested a review from tobrun February 27, 2020 02:29
@Chaoba
Copy link
Contributor Author

Chaoba commented Feb 27, 2020

Binding pr in core sdk: mapbox/mapbox-gl-native#16236

tobrun
tobrun reviewed Feb 27, 2020
View reviewed changes
Copy link
Member

@tobrun tobrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think for maxZoom and minZoom we expose attributes configuration through attrs.xml. Could you check if that is correct? if yes, could you add a similar setup of these APIs?

@Chaoba Chaoba mentioned this pull request Feb 28, 2020
Merged
@Chaoba Chaoba merged commit 17b19b3 into master Feb 28, 2020
@Chaoba Chaoba deleted the kl-min-max-pitch branch February 28, 2020 10:17
@Chaoba Chaoba mentioned this pull request Mar 3, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tobrun tobrun tobrun approved these changes

Assignees

@Chaoba Chaoba

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Platform bindings for min/max pitch setting
2 participants
@Chaoba @tobrun