Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

Add interface for stretchable image #314

Merged
merged 5 commits into from
Apr 16, 2020
Merged

Add interface for stretchable image #314

merged 5 commits into from
Apr 16, 2020

Conversation

Chaoba
Copy link
Contributor

@Chaoba Chaoba commented Apr 8, 2020

<changelog>Add interface and demo for stretchable image.</changelog>

#Resolve #147

image

@Chaoba Chaoba requested a review from tobrun April 8, 2020 13:10
@chloekraw chloekraw added this to the release-water milestone Apr 8, 2020
@Chaoba Chaoba self-assigned this Apr 15, 2020
Copy link
Member

@tobrun tobrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🚀

@tobrun
Copy link
Member

tobrun commented Apr 15, 2020

👀 @mapbox/maps-android

@Chaoba Chaoba merged commit 1cb8fb7 into master Apr 16, 2020
@Chaoba Chaoba deleted the kl-stretch-image branch April 16, 2020 06:31
@chloekraw
Copy link
Contributor

@mapbox/maps-android how is the documentation for Style.addImage generated?

Will this PR add stretchX, stretchY, and content as valid options on Style.addImage in our SDK docs?

@langsmith
Copy link
Contributor

@mapbox/maps-android how is the documentation for Style.addImage generated?

@chloekraw , I generate the API reference docs by running make android-javadoc on the command line in this repo's root folder.

The addImage() explanations in https://docs.mapbox.com/android/api/map-sdk/9.1.0/com/mapbox/mapboxsdk/maps/Style.html come from what's actually written in the inline docs as the SDK is worked on in Android Studio. I'm not writing them from scratch after the release is done or anything. make android-javadoc automatically turns the inline docs into the reference doc HTML files. Happy to walk through the process and screen share to show you what I mean.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Example stretchable icons
4 participants