Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

Add bindings for circle-sort-key #322

Merged
merged 4 commits into from
Apr 15, 2020
Merged

Add bindings for circle-sort-key #322

merged 4 commits into from
Apr 15, 2020

Conversation

chloekraw
Copy link
Contributor

<changelog>Added methods to set and get the sort key of features in a CircleLayer at runtime. Features with a higher sort key will appear above features with a lower sort key.</changelog>

Fixes #197

@chloekraw chloekraw requested review from tobrun and Chaoba April 15, 2020 03:34
@chloekraw
Copy link
Contributor Author

@LukasPaczos @tobrun I noticed running the script included changes that are also in #319. Should I manually override the changes that don't relate to circle sort key in a new commit? Let me know what the best way forward is.

Copy link
Member

@LukasPaczos LukasPaczos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @chloekraw @Chaoba!

Because of the generation script changes needed to expose include LocationIndicatorLayer, we cannot fully use the script right now and include all the available bindings. The current contents of the PR look good to me, so let's go ahead and merge and I'll resolve the conflicts when rebasing #319.

@Chaoba Chaoba merged commit 77d0d5e into master Apr 15, 2020
@Chaoba Chaoba deleted the kl-update-style-generate branch April 15, 2020 09:57
@chloekraw
Copy link
Contributor Author

@LukasPaczos thanks! Looks like @Chaoba’s commit removed the non-circle-sort-key changes so hopefully you don’t run into too many merge conflicts when you rebase.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port circle-sort-key
3 participants