This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
CP #325 #338
Merged
CP #325 #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The compass engine has not adjusted the heading according to the device orientation. This causes wrong heading if the device is not in its normal orientation.
…r events, otherwise, only one sensor value is updated in each heading update. Especially, there may be more TYPE_ACCELEROMETER events in some devices, such that TYPE_MAGNETIC_FIELD events could be dropped easily. Also, it took longer time to reflect the latest heading if there are few events, due to the lowPassFilter.
… placed horizontally or vertically. The previous logic may return wrong heading when the device is placed horizontally.
This makes it possible to use a different indicator for the unreliable case, instead of just changing the RenderMode to NORMAL.
tobrun
approved these changes
Apr 23, 2020
|
🎉 Edited the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CP #325. Thanks again for your contribution @ystsoi!
I cleaned up the comments a bit and removed the uncertain vector drawable since it wouldn't be used by default.
<changelog>Improve the default compass engine's heading calculation and push updates even when uncertain. (h/t @ystsoi)</changelog>