This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
Expose gesture protection area when tracking location #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobrun
approved these changes
Apr 29, 2020
This makes sure that we need to meet all of the thresholds and actually start the fling camera animation before dispatching the onFLing event. Previously, it would be dispatched as soon as the compat detector fired.
LukasPaczos
force-pushed
the
lp-location-protected-gesture-area
branch
from
504c2ba
to
7e9e734
Compare
This option provides a way of defining a protected area on the screen which prevents breaking the camera location when executing a multi finger gesture as long as the focal point of the gesture is within this area.
LukasPaczos
force-pushed
the
lp-location-protected-gesture-area
branch
from
5c8a961
to
b581f3e
Compare
LukasPaczos
force-pushed
the
lp-location-protected-gesture-area
branch
from
b581f3e
to
d19b139
Compare
This was referenced Apr 30, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings 2 changes:
Currently, the PR is based on the gesture's lib snapshot but whenever the changes are accepted, I'll bump the version of the library to a stable one.