This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
[ci] Update CI image to use android-ndk-21b. #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pengdev
force-pushed
the
peng-update-ci-image
branch
from
2d42de9
to
5f79a69
Compare
tobrun
reviewed
Jun 2, 2020
| @@ -6,7 +6,7 @@ buildscript { | |||
| jcenter() | |||
| } | |||
| dependencies { | |||
| classpath 'com.android.tools.build:gradle:3.5.0' | |||
| classpath 'com.android.tools.build:gradle:3.6.3' | |||
There was a problem hiding this comment.
can we do 4.0.0 instead? AS 4.0 stable was released last week
There was a problem hiding this comment.
4.0.0 introduced some breaking change, which need to be resolved. I can try to resolve the issues.
There was a problem hiding this comment.
It seems there is an incompatibility issue with the android-sdk-versions-plugin and gradle plugin 4.0.0, the error is printed as follows:
Cannot cast object 'task ':MapboxGLAndroidSDK:generateDebugBuildConfig' property 'versionCode'' with class 'org.gradle.api.internal.provider.DefaultProperty' to class 'java.lang.Integer'
cc @harvsu
pengdev
force-pushed
the
peng-update-ci-image
branch
from
82a39d4
to
2f2b19d
Compare
tobrun
approved these changes
Jun 2, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates CI image to use android-ndk-21b.