Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

Fix remove source memory leak. #412

Merged
merged 2 commits into from
Jun 3, 2020
Merged

Fix remove source memory leak. #412

merged 2 commits into from
Jun 3, 2020

Conversation

Chaoba
Copy link
Contributor

@Chaoba Chaoba commented Jun 2, 2020

<changelog>Fix the memory leak while adding and removing sources.</changelog>

#Resolve #405

@Chaoba Chaoba requested a review from tobrun June 2, 2020 10:34
@tarigo tarigo self-requested a review June 2, 2020 11:46
@tobrun
Copy link
Member

tobrun commented Jun 2, 2020

CI fails with

Abort message: '/src/MapboxGLAndroidSDK/src/cpp/style/sources/custom_geometry_source.cpp:113: void mbgl::android::CustomGeometrySource::releaseThreads(): assertion "javaPeer" failed'

This is because CustomGeometrySource is a bit different Source as the others and we might need to find a separate solution for this one.

@Chaoba Chaoba merged commit b16d47c into master Jun 3, 2020
@Chaoba Chaoba deleted the kl-source-leak branch June 3, 2020 09:26
Chaoba pushed a commit to mapbox/mapbox-gl-native that referenced this pull request Jul 16, 2020
Chaoba pushed a commit that referenced this pull request Jul 16, 2020
Chaoba pushed a commit that referenced this pull request Jul 16, 2020
Chaoba pushed a commit that referenced this pull request Jul 16, 2020
* Bump mapbox java to v4.9.1

* Fix remove source memory leak.
Cherry-pick from #412
emerson233 pushed a commit to emerson233/mapbox-gl-native-android that referenced this pull request Jul 21, 2021
* Fix remove source memory leak.

* Fix testcase crash
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Memory leak in native code
3 participants