Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

Cherry-pick (#429) Not change file source status while changing cache path. #457

Closed
wants to merge 1 commit into from

Conversation

Chaoba
Copy link
Contributor

@Chaoba Chaoba commented Jul 6, 2020

This pr cherry-pick #429 java changes.
Resolves #451

* Not change file source status while changing cache path.

* Fix test cases error.

* Change default state of FileSource to active.

(cherry picked from commit 967a57f)
@Chaoba Chaoba self-assigned this Jul 6, 2020
@Chaoba Chaoba requested a review from tobrun July 6, 2020 02:30
@tobrun tobrun added this to the release-xoai milestone Jul 9, 2020
@tobrun
Copy link
Member

tobrun commented Jul 9, 2020

Could you rebase once #465 lands?

@Chaoba
Copy link
Contributor Author

Chaoba commented Jul 9, 2020

Could you rebase once #465 lands?

Sure

@tobrun
Copy link
Member

tobrun commented Jul 9, 2020

To make CI pass for #465, I had to CP the commit from this PR to it. Let's follow up in #465

@tobrun tobrun closed this Jul 9, 2020
@tobrun tobrun deleted the kl-cherrypick-filesource branch July 9, 2020 09:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bring back changes from #429
2 participants