Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

Check isLocationTracking in the right place #504

Merged
merged 2 commits into from
Jul 28, 2020
Merged

Check isLocationTracking in the right place #504

merged 2 commits into from
Jul 28, 2020

Conversation

Chaoba
Copy link
Contributor

@Chaoba Chaoba commented Jul 28, 2020

Check isLocationTracking should be done after the mode is changed

Copy link
Member

@LukasPaczos LukasPaczos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a unit test as well?

@Chaoba Chaoba merged commit 9db4bda into develop Jul 28, 2020
@Chaoba Chaoba deleted the kl-tracking branch July 28, 2020 13:13
tarigo pushed a commit that referenced this pull request Jul 30, 2020
* Check isTracking in the right place

* Add test case
tarigo pushed a commit that referenced this pull request Jul 30, 2020
* Check isTracking in the right place

* Add test case
@knov knov added this to the release-yerba-maté milestone Aug 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants