Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

Expose indicator position change listener #515

Merged
merged 1 commit into from
Aug 4, 2020

Conversation

JunDai
Copy link
Contributor

@JunDai JunDai commented Aug 4, 2020

<changelog>Expose OnIndicatorPositionChangedListener which will be invoked when indicator position changes.</changelog>

Add this listener for Navigation UI SDK to improve vanishing route line feature.

cc: @cafesilencio / @LukasPaczos

@JunDai JunDai requested a review from LukasPaczos August 4, 2020 06:03
@JunDai JunDai added the feature 🍏 New feature or request label Aug 4, 2020
@JunDai JunDai force-pushed the jd-indicator-position-change-listener branch from c0489fa to c388561 Compare August 4, 2020 06:12
Copy link
Member

@LukasPaczos LukasPaczos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be great to add a test in LocationLayerControllerTest.java as well. Other than that, LGTM 👍
EDIT: The test's already there! I missed it when scrolling.

@LukasPaczos LukasPaczos requested a review from a team August 4, 2020 09:43
@JunDai JunDai merged commit 47df8cf into master Aug 4, 2020
@JunDai JunDai deleted the jd-indicator-position-change-listener branch August 4, 2020 15:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature 🍏 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants