Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

Adapt core library v4.0.0 breaking changes. #548

Merged
merged 3 commits into from
Sep 4, 2020

Conversation

tarigo
Copy link
Contributor

@tarigo tarigo commented Sep 3, 2020

Summary of changes:

  • remove LocalGlyphRasterizer, it's now a part of core, pure C++ implementation;
  • LocationIndicatorLayer: deprecate getImageTiltDisplacement method, introduce it's getImagePitchDisplacement replacement;
  • the same as above for LocationPropertyFactory's imageTiltDisplacement methods;
  • change values in HeatmapLayerTest.testHeatmapRadiusAsConstant and SymbolLayerTest.testSymbolSpacingAsConstant
    tests to fit value limits for the style layer properties;

Summary of changes:
 - remove `LocalGlyphRasterizer`, it's now a part of core, pure C++ implementation;
 - LocationIndicatorLayer: deprecate `getImageTiltDisplacement` method, introduce it's `getImagePitchDisplacement` replacement;
 - the same as above for LocationPropertyFactory's imageTiltDisplacement methods;
 - change values in HeatmapLayerTest.testHeatmapRadiusAsConstant and SymbolLayerTest.testSymbolSpacingAsConstant
   test to fit value limits for the style layer properties;
@tarigo tarigo force-pushed the tarigo_adjust_to_maps_v4.0.0 branch from 1f750d2 to 1728776 Compare September 3, 2020 13:42
@tarigo tarigo self-assigned this Sep 3, 2020
@tarigo tarigo added the p0 label Sep 3, 2020
@tarigo tarigo requested review from a team and pengdev September 3, 2020 19:41
@tarigo tarigo marked this pull request as ready for review September 3, 2020 19:45
Copy link
Contributor

@Chaoba Chaoba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Others look good to me

@tarigo tarigo merged commit d9c14cb into master Sep 4, 2020
@tarigo tarigo deleted the tarigo_adjust_to_maps_v4.0.0 branch September 4, 2020 06:25
@Chaoba Chaoba added this to the v9.5.0 (release-zinfandel) milestone Sep 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants