Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

[egl] add additional check against eglcontext #723

Merged
merged 1 commit into from
Jan 20, 2022
Merged

[egl] add additional check against eglcontext #723

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions ...K/src/main/java/com/mapbox/mapboxsdk/maps/renderer/glsurfaceview/MapboxGLSurfaceView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -432,6 +432,10 @@ boolean createSurface() {
Log.e(TAG, "mEglConfig not initialized");
return false;
}
if (mEglContext == null) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonder what the outcome would be, if we skip init here black map?
Also, to help debugging, I'd probably enriched logs a bit, like Could not create surface for drawing, mEglContext not initialized

Log.e(TAG, "mEglContext not initialized");
return false;
}

/*
* The window size has changed, so we need to create a new
Expand Down