This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
Invoke cancelable callback when zoom/tilt while tracking is ignored #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobrun
approved these changes
Dec 3, 2019
| @@ -739,14 +739,15 @@ public void zoomWhileTracking(double zoomLevel, long animationDuration, | |||
| @Nullable MapboxMap.CancelableCallback callback) { | |||
| checkActivationState(); | |||
| if (!isLayerReady) { | |||
| notifyUnsuccessfulCameraOperation(callback, null); | |||
There was a problem hiding this comment.
Would it be useful to add a message for this occurrence as well? or would that spam the user?
There was a problem hiding this comment.
I'd rather skip it as this would happen only when component is paused, so it's expected that it'll ignored the updates.
LukasPaczos
added a commit
that referenced
this pull request
Dec 3, 2019
|
Chagelog in #85. |
LukasPaczos
added a commit
that referenced
this pull request
Dec 3, 2019
harvsu
pushed a commit
that referenced
this pull request
Apr 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make the callbacks more reliable, we should ensure to invoke them even when the transition is ignored.