This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
Expose getter for the view used for rendering OpenGL #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasPaczos
approved these changes
Dec 3, 2019
...oidSDKTestApp/src/androidTest/java/com/mapbox/mapboxsdk/testapp/maps/RenderViewGetterTest.kt
Outdated
Show resolved
Hide resolved
...oidSDKTestApp/src/androidTest/java/com/mapbox/mapboxsdk/testapp/maps/RenderViewGetterTest.kt
Outdated
Show resolved
Hide resolved
tobrun
force-pushed
the
tvn-renderview-getter
branch
from
1caf7ff
to
a0d3150
Compare
harvsu
pushed a commit
that referenced
this pull request
Apr 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a proposal to close #77, alternatively we could opt to assign id to the render surface, so a user can rely on
mapView.findViewById(R.id.renderSurface)instead.@mapbox/maps-android wdyt?