Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

Introduce limited axis scrolling #108

Merged
merged 1 commit into from Jan 10, 2020
Merged

Introduce limited axis scrolling #108

merged 1 commit into from Jan 10, 2020

Conversation

captainbarbosa
Copy link
Contributor

@captainbarbosa captainbarbosa commented Dec 16, 2019 •
edited

Addresses #107 by introducing a new option to limit vertical and horizontal scrolling.

Developers can limit scrolling for users both horizontally or vertically with this change.

Usage:

mapView.scrollingMode = MGLPanScrollingModeVertical

or

mapView.scrollingMode = MGLPanScrollingModeHorizontal

Default:

mapView.scrollingMode = MGLPanScrollingModeDefault

Below is an example of setting MGLPanScrollingModeVertical:

scrollington_boat_factory

@captainbarbosa captainbarbosa requested a review from a team December 16, 2019 22:52
@captainbarbosa captainbarbosa self-assigned this Dec 16, 2019
@captainbarbosa captainbarbosa added the enhancement New feature or request label Dec 16, 2019
julianrex
julianrex reviewed Dec 17, 2019
View reviewed changes
platform/ios/src/MGLMapView.h Outdated Show resolved Hide resolved
platform/ios/src/MGLMapView.mm Outdated Show resolved Hide resolved
@captainbarbosa captainbarbosa force-pushed the nb-limit-scrolling branch 2 times, most recently from 3f20bb4 to 1e8151d Compare January 9, 2020 23:10
@captainbarbosa
Copy link
Contributor Author

@julianrex I renamed some things, could you re-review please?

julianrex
julianrex approved these changes Jan 10, 2020
View reviewed changes
Copy link
Contributor

@julianrex julianrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thank you! Just the one log to remove please.

@captainbarbosa
Introduce limited axis scrolling
fc268d8 
MGLUserScrollingMode -> MGLPanScrollingMode

Add changelog entry

Remove NSLog
@captainbarbosa captainbarbosa merged commit 309e226 into master Jan 10, 2020
@captainbarbosa captainbarbosa deleted the nb-limit-scrolling branch January 10, 2020 18:04
@malwoodsantoro malwoodsantoro mentioned this pull request Jan 16, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@julianrex julianrex julianrex approved these changes

Assignees

@captainbarbosa captainbarbosa

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@captainbarbosa @julianrex