This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
Update to application state management and associated view setup and rendering #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianrex
force-pushed
the
jrex/background-crash-orig-pr-14222-pt1
branch
from
September 14, 2020 15:45
6ea14a8
to
31bec0c
Compare
fabian-guerra
approved these changes
Sep 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Some minor comments.
fabian-guerra
pushed a commit
that referenced
this pull request
Sep 14, 2020
Closed
fabian-guerra
added a commit
that referenced
this pull request
Sep 14, 2020
* changing the default size for approx ring border when zoomed out (#429) * Approximate Location "Puck" logic updates (#427) * updates to approximate puck drawing logic * removing unused header * Allow for transitive dependencies (#431) * Fix content insets when automaticallyAdjustsScrollViewInsets is set to NO (#420) * Fix an issue when automaticallyAdjustContentInset is set to NO * Update tests to account for safe areas on iOS 11 * Update changelog * Update method documentation * Update to gl-native 5.0.0 (#438) * Update to application state management and associated view setup and rendering (#432) Co-authored-by: Neel Mistry <Neel.mistry@mapbox.com> Co-authored-by: Fredrik Karlsson <bjorn.fredrik.karlsson@gmail.com> Co-authored-by: Julian Rex <julian.rex@mapbox.com>
mappy-mobile
pushed a commit
to Mappy/mapbox-gl-native-ios
that referenced
this pull request
Sep 17, 2020
Fix guidance views json parsing.
This was referenced Apr 30, 2021
reezer
pushed a commit
to reezer/maplibre-gl-native
that referenced
this pull request
Apr 30, 2021
…k to foreground. Includes relevant changes from Mapbox PR (mapbox/mapbox-gl-native-ios#432).
petr-pokorny-1
pushed a commit
to maplibre/maplibre-native
that referenced
this pull request
May 10, 2021
* Use DisplayLink to prevent crashes in willResignActive * Fixed screen freeze issue in the DisplayLink PR when bringing app back to foreground. Includes relevant changes from Mapbox PR (mapbox/mapbox-gl-native-ios#432). Co-authored-by: Jukka Hietanen <jukka.hietanen@accelbit.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is essentially a port/continuation of mapbox/mapbox-gl-native#14222 in this repo, and addresses a number of issues in #440.
It adds:
MGLApplication
protocol to the SDK, allowing us to mock application events for testing. This also paves the way for removingUIApplication.shared
references from the SDK.emergencyRecreateGL
method, that has been defunct for a while.MGLMapView.renderingInInactiveStateEnabled
) to disable rendering when the application resigns active. This should be considered prone to change.