This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
Fix scalebar ornament triggers unnecessary layoutSubviews #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZiZasaurus
reviewed
Oct 14, 2020
julianrex
approved these changes
Oct 14, 2020
| toItem:nil | ||
| attribute:NSLayoutAttributeNotAnAttribute | ||
| multiplier:1 | ||
| constant:16]; |
There was a problem hiding this comment.
Do we have an existing constant for this?
There was a problem hiding this comment.
| relatedBy:NSLayoutRelationEqual | ||
| toItem:self | ||
| attribute:NSLayoutAttributeWidth | ||
| multiplier:.5 |
There was a problem hiding this comment.
Is half the width of the view essentially the maximum size possible? How does this impact running on iPad?
There was a problem hiding this comment.
It may be a bit long on the iPad, but I think it's acceptable 😂
| CGFloat barWidth = totalBarWidth/self.bars.count; | ||
|
|
||
| BOOL RTL = [self usesRightToLeftLayout]; | ||
| CGFloat halfLabelWidth = ceil(self.lastLabelWidth/2); | ||
| CGFloat barOffset = RTL ? halfLabelWidth : 0.0; | ||
|
|
||
| self.containerView.frame = CGRectMake(barOffset, | ||
| intrinsicContentHeight - MGLBarHeight, | ||
| CGFloat containerViewX = self.isOnScreenRight ? self.bounds.size.width - totalBarWidth - barOffset : barOffset; |
There was a problem hiding this comment.
Does this also need the halfLabelWidth if on the right hand side?
There was a problem hiding this comment.
It needs the barOffset(calculated by halfLabelWidth ) for layout direction right to left on either side. Otherwise, labels will display like this 👇
ZiZasaurus
approved these changes
Oct 14, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #502