Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[android] Write "collator" wrappers for Expression.java #12268

Closed
ChrisLoer opened this issue Jun 29, 2018 · 1 comment · Fixed by #12688
Closed

[android] Write "collator" wrappers for Expression.java #12268

ChrisLoer opened this issue Jun 29, 2018 · 1 comment · Fixed by #12688
Labels
Android Mapbox Maps SDK for Android

Comments

@ChrisLoer
Copy link
Contributor

Follow-on for #11869: Android now supports "collator" expressions, but they're not directly exposed via the SDK. Collator expressions take a dictionary-style object as an argument, e.g.:

["collator", {"case-sensitive": false, "diacritic-sensitive": true, "locale": "en"}]

This is a new pattern so we'll have to figure out the right Java-appropriate way to wrap it.

/cc @LukasPaczos @tobrun

@LukasPaczos LukasPaczos added the Android Mapbox Maps SDK for Android label Jul 2, 2018
@tobrun tobrun added this to the android-v6.3.0 milestone Jul 4, 2018
@tobrun tobrun assigned tobrun and unassigned LukasPaczos Jul 6, 2018
@tobrun
Copy link
Member

tobrun commented Jul 6, 2018

Looking into this and noticing that the expression evaluate is expecting an object, this isn't yet supported in jni for our filter/properties conversion system (see todo here). Currently taking the approach to represent an object as Map<String, Object> where the key/value represent the fields of the object.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants