Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Consolidate color conversion into color utils #12381

Closed
tobrun opened this issue Jul 13, 2018 · 1 comment · Fixed by #13337
Closed

Consolidate color conversion into color utils #12381

tobrun opened this issue Jul 13, 2018 · 1 comment · Fixed by #13337
Assignees
Labels
Android Mapbox Maps SDK for Android SEMVER-MAJOR Requires a major release according to Semantic Versioning rules

Comments

@tobrun
Copy link
Member

tobrun commented Jul 13, 2018

In multiple places in the code base we currently convert from an Android int color to rgba float[] or string equivalent. We have 2 implementations of these in our codebase ColorUtils and PropertyFactory. In #12377, we are also adding Android int color conversion to rgba variant that gl uses (values range from 0-1).

For 4.3.0, we should start deprecating the PropertyFactory variant.
Cleanup can happen as part of next major release.

@tobrun tobrun added SEMVER-MAJOR Requires a major release according to Semantic Versioning rules Android Mapbox Maps SDK for Android labels Jul 13, 2018
@tobrun
Copy link
Member Author

tobrun commented Jul 13, 2018

Deprecation happening in #12377

@lilykaiser lilykaiser added this to the android-v7.0.0 milestone Jul 30, 2018
@tobrun tobrun removed this from the android-v7.0.0 milestone Sep 19, 2018
@osana osana self-assigned this Oct 25, 2018
@tobrun tobrun added this to the android-v7.0.0 milestone Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android SEMVER-MAJOR Requires a major release according to Semantic Versioning rules
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants