-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Unify behavior of removing sources and layers by the ID #12601
Comments
Additional observations when it comes to adding/removing sources and layers: Difference between
|
This issue has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions. |
This issue has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions. |
I this ticket still relevant, especially in the context of Carbon @tarigo? |
For Carbon - no. |
mbgl::android::NativeMapView#removeLayerById
invoked byMapboxMap#removeLayer(String)
doesn't return control over the core layer to the peer, therefore, callingresults in a
CannotAddLayerException
.This is documented as follows:
However, for
Source
s removed byID
we are first looking the source up and removing by reference, even though the javadoc states the same as forLayer
s:We should unify this logic to express the same behavior for layers and sources or simply update the documentation for sources.
The text was updated successfully, but these errors were encountered: