Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

port updating tile rendering after addImage and removeImage #16021

Closed
ansis opened this issue Dec 6, 2019 · 1 comment
Closed

port updating tile rendering after addImage and removeImage #16021

ansis opened this issue Dec 6, 2019 · 1 comment
Labels
archived Archived because of inactivity GL JS parity For feature parity with Mapbox GL JS

Comments

@ansis
Copy link
Contributor

ansis commented Dec 6, 2019

port mapbox/mapbox-gl-js#9016

I haven't checked whether this issue exists in -native. If it doesn't, its probably still reparsing all tiles when an image is added or removed. This pr skips all tiles that don't use the image.

A tile needs to be reparsed in order for it to use the new image. Reloading all tiles whenever an image is added would be expensive. For example:

  • load a map
  • add an image and use it in a geojson overlay
    You don't want adding that image to make the basemap tiles be reloaded.

To get around that we track all the image ids used by each tile and only reload tiles that depend on images that changed.

@ansis ansis added the GL JS parity For feature parity with Mapbox GL JS label Dec 6, 2019
@stale stale bot added the archived Archived because of inactivity label Jun 3, 2020
@stale
Copy link

stale bot commented Jun 3, 2020

This issue has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions.

@stale stale bot closed this as completed Jun 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived Archived because of inactivity GL JS parity For feature parity with Mapbox GL JS
Projects
None yet
Development

No branches or pull requests

1 participant