Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Cleanup + refactor gradle files #6009

Closed
7 tasks
tobrun opened this issue Aug 15, 2016 · 3 comments · Fixed by #6896
Closed
7 tasks

Cleanup + refactor gradle files #6009

tobrun opened this issue Aug 15, 2016 · 3 comments · Fixed by #6896
Assignees
Labels
Android Mapbox Maps SDK for Android refactor

Comments

@tobrun
Copy link
Member

tobrun commented Aug 15, 2016

Our gradle files are growing large and complex.
I suggest refactoring some tasks into external build scripts:

  • javadoc.gradle
  • maven.gradle
  • make.gradle
  • dev_config.gradle
  • ...

How to config project using external build script

build.gradle

apply from: 'other.gradle'

other.gradle

println "configuring $project"
task hello << {
    println 'hello from other script'
}

Additional tasks:

cc @mapbox/android

@tobrun tobrun added refactor Android Mapbox Maps SDK for Android labels Aug 15, 2016
@tobrun tobrun added this to the android-v4.2.0 milestone Aug 15, 2016
@zugaldia
Copy link
Member

👍 I really like doing this to my .gradle files and also makes sense from a consistency point of view as we're already following this approach on MAS. E.g.: https://github.com/mapbox/mapbox-java/blob/master/libandroid/lib/build.gradle#L47-L49.

@tobrun
Copy link
Member Author

tobrun commented Aug 15, 2016

Ah now I remember where I had seen that before, 🙇 @zugaldia

@tobrun
Copy link
Member Author

tobrun commented Aug 16, 2016

Moving of the milestone, no requirement

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android refactor
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants