Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Rework Android make targets #6697

Closed
5 tasks done
tobrun opened this issue Oct 14, 2016 · 6 comments · Fixed by #6958
Closed
5 tasks done

Rework Android make targets #6697

tobrun opened this issue Oct 14, 2016 · 6 comments · Fixed by #6958
Assignees
Labels
Android Mapbox Maps SDK for Android build

Comments

@tobrun
Copy link
Member

tobrun commented Oct 14, 2016

Our current set of make targets have grown naturally over time, time to clean these up, streamline naming and introduce some usefull new ones:

compile

make android-lib-{abi} (same, compiles .so file for a specific abi)
make android (same, compiles arm-v7 abi and compiles Android test app)
make android-core-test (new, todo #5456, only compile if needed)
make android-ui-test (rename, only compiles 2 test apk for firebase on bitrise, no native build?)

run

make run-android (new, make android + install/run apk on device)
make run-android-core-test (new, todo #5456)
make run-android-unit-test (rename, unit tests on development machine)
make run-android-ui-test (new, instrumentation tests on device)

generate

make style-code-android (same, remains for parity with other bindings)
make test-code-android (rename, replaces current android-generate-test)

TODO:

  • make android-ui-test (rename)
  • make run-android (add)
  • make run-android-unit-test (rename)
  • make-run-android-ui-test (new)
  • make test-code-android (rename)

cc @mapbox/android

@tobrun tobrun added build Android Mapbox Maps SDK for Android labels Oct 14, 2016
@tobrun
Copy link
Member Author

tobrun commented Oct 14, 2016

Other possible targets we could consider:

  • ndk-stack
  • adb device management
  • pull offline database from rooted device
  • code coverage
  • javadoc
  • release?

@zugaldia
Copy link
Member

Love it. I'm missing apackage from the list, any plans for it?

@tobrun
Copy link
Member Author

tobrun commented Oct 17, 2016

I missed that one, where is that name apackage coming from?
I'm personally not a big fan of the naming.

@zugaldia
Copy link
Member

@tobrun Not sure either, probably is short for "android package", feel free to rename it (remember this is the target used in bitrise.yml so that needs to be updated too).

@tobrun
Copy link
Member Author

tobrun commented Nov 8, 2016

@zugaldia the apackage seems to be the xpackage convention across platforms. Eg. iOS has ipackage. I'm going to keep this name for consistency.

@tobrun tobrun self-assigned this Nov 8, 2016
@tobrun tobrun added this to the android-v5.0.0 milestone Nov 8, 2016
@tobrun
Copy link
Member Author

tobrun commented Nov 8, 2016

Final list of make configs is found in the PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android build
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants