Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Generate MGLLight automatically from style specification #9086

Closed
1ec5 opened this issue May 23, 2017 · 2 comments
Closed

Generate MGLLight automatically from style specification #9086

1ec5 opened this issue May 23, 2017 · 2 comments
Labels
build iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS release blocker Blocks the next final release runtime styling
Projects
iOS SDK v3.6.0 tracking
Milestone
ios-v3.6.0

Comments

@1ec5
Copy link
Contributor

1ec5 commented May 23, 2017

MGLLight.h and MGLLight.mm are hand-crafted but should be generated automatically from the style specification. This will help us avoid inconsistencies like #9085 and also future-proof the API for any future additions to this part of the style specification.

/ref #9043
/cc @fabian-guerra @ivovandongen
@1ec5 1ec5 added build iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS runtime styling labels May 23, 2017
@1ec5 1ec5 mentioned this issue May 23, 2017
Merged
4 tasks
@ivovandongen
Copy link
Contributor

Also take a look at what @tobrun is doing for Android: #9013

@fabian-guerra fabian-guerra added this to the ios-v3.6.0 milestone May 26, 2017
@fabian-guerra fabian-guerra added this to Build & Packaging in iOS SDK v3.6.0 tracking May 26, 2017
@boundsj boundsj added the release blocker Blocks the next final release label May 26, 2017
@fabian-guerra fabian-guerra moved this from Build & Packaging to iOS-v3.6.0 In Progress in iOS SDK v3.6.0 tracking May 26, 2017
@fabian-guerra fabian-guerra mentioned this issue Jun 13, 2017
Merged
@fabian-guerra fabian-guerra moved this from iOS-v3.6.0 In Progress to iOS-v3.6.0 Completed in iOS SDK v3.6.0 tracking Jun 16, 2017
@fabian-guerra
Copy link
Contributor

Fixed in #9260

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
build iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS release blocker Blocks the next final release runtime styling
Projects
No open projects
iOS SDK v3.6.0 tracking
iOS-v3.6.0 Completed
Milestone
ios-v3.6.0
Development

No branches or pull requests
4 participants
@boundsj @ivovandongen @1ec5 @fabian-guerra