Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Support adding SDF icons in addImage #9847

Closed
lbud opened this issue Aug 23, 2017 · 5 comments · Fixed by #12181
Closed

Support adding SDF icons in addImage #9847

lbud opened this issue Aug 23, 2017 · 5 comments · Fixed by #12181
Labels
Android Mapbox Maps SDK for Android GL JS parity For feature parity with Mapbox GL JS

Comments

@lbud
Copy link
Contributor

lbud commented Aug 23, 2017

mapbox/mapbox-gl-js#5181 needs port.

@lbud lbud added the GL JS parity For feature parity with Mapbox GL JS label Aug 23, 2017
@kkaefer kkaefer added the Core The cross-platform C++ core, aka mbgl label Aug 25, 2017
@1ec5
Copy link
Contributor

1ec5 commented May 25, 2018

#7300 makes use of an existing API to make mbgl interpret an image as an SDF image when adding it to the style. Is there anything left to do here in mbgl?

@samfader
Copy link
Contributor

samfader commented Jun 6, 2018

@1ec5 @lbud would this be an appropriate place to mention that there is no Android solution for this as of yet? As in, as far as I can tell, there's no way to add SDF icons via addImage in the Android SDK. Or should that be ticketed separately?

@tobrun tobrun added this to the android-v6.3.0 milestone Jun 11, 2018
@1ec5 1ec5 added Android Mapbox Maps SDK for Android and removed Core The cross-platform C++ core, aka mbgl labels Jun 11, 2018
@tobrun
Copy link
Member

tobrun commented Jun 20, 2018

Before enabling the sdf flag in Style.addImage:

device-2018-06-20-133259

After enabling the sdf flag in Style.addImage + enabling icon-color tinting:

device-2018-06-20-133844

@curvenut
Copy link

Hi,

Did you use a SDF image ?

How did you add the SDF image ?
I am trying to do exactly what you are doing without sucess. In fact I dont kown how to create a SDF image.

Thanks for help

Before enabling the sdf flag in Style.addImage:

device-2018-06-20-133259

After enabling the sdf flag in Style.addImage + enabling icon-color tinting:

device-2018-06-20-133844

@tobrun
Copy link
Member

tobrun commented Nov 15, 2018

@curvenut icons created through Android studio or copied from material spec are sdf compatible. In Android terms, vector drawables are sdf compatible.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android GL JS parity For feature parity with Mapbox GL JS
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants