-
Notifications
You must be signed in to change notification settings - Fork 8
Why not implementing SMCalloutView's delegate method calloutViewClicked in RMMapView? #422
Comments
On the delegate front, we took the MapKit-like approach of exposing Exposing |
About the callout delegate, I can see that you've added tap recognizer to accessory views and ignored the only tap delegate provided by SMCalloutView. In my project I need to default the touch on the whole callout todo something like my right accessory view, but i have no way of doing that without the said delegate method. And about the exposing calloutview, i have no idea how to request a pull! Maybe if you point me to somewhere I can learn how to request a pull on github? On Tue, Mar 18, 2014 at 8:18 PM, Justin R. Miller
|
Sure. To be clear, I ask for a pull request of code for the feature so that 1) we can comment on it inline and work through possible acceptance and 2) so that folks who want the features are motivated to add them. GitHub's reference: |
Thanks, will take a look asap— On Tue, Mar 18, 2014 at 8:48 PM, Justin R. Miller
|
OK, I read those articles, now I'm ready for your pull request. But I'm not currently at work (GMT+3:30 time zone), I will address this tomorrow morning.Thanks On Tue, Mar 18, 2014 at 8:50 PM, Mohammad Porooshani porooshani@gmail.com
|
You actually send the pull to us, via forking the project, making some commits to your copy, and then initiating a pull request to our copy. We then modify and/or accept it into our copy. |
I'm trying to do what you asked for and I noticed that just like earlier today at work, when I clone map box git and checkout |
On latest |
I've requested a pull and added my commits, hope I did it right! (My First pull request: very exciting) |
|
Make sure you are doing a recursive clone / submodule update. See this gist for a successful run I just did: https://gist.github.com/incanus/3f63059e54e9ac2d0df8 |
Any movement here @mohpor? |
I will look into it today and let you know. |
@incanus, done. |
It seems kindda strange that RMMapView _doesn't_ implement SMCalloutViewDelegate's method
calloutViewClicked:
and pass it to RMMapViewDelegate!Anyone with a need to handle accessory buttons' tap, might be interested in the callout taps too, it is in place you just need to re-delegate it!
and while we are at it, I guess it seems like a logical request to make _currentCallout public (a property), this way the developer has access to the callout and can handle anything he wants, including adding custom views for the title and all.
I know it might make RMMapView tightly coupled with SMCalloutView but we got to make a hard decision and decide and use SMCalloutView as a core component and rely on it.
The text was updated successfully, but these errors were encountered: