TurfMeasurement#envelope #1020
Merged
TurfMeasurement#envelope #1020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osana
approved these changes
May 2, 2019
osana
reviewed
May 3, 2019
| * @since 4.8.0 | ||
| */ | ||
| public static double[] bbox(GeoJson geoJson) { | ||
| BoundingBox boundingBox = geoJson.bbox(); |
There was a problem hiding this comment.
One thing. I am not convinced that we can trust the bbox that came with the geoJson.
There was a problem hiding this comment.
capturing from the spec, this can be provided though seems optional. If bbox isn't implemented, it will try to base the bbox on the actual geometries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for https://turfjs.org/docs/#envelope. It also fixes up bbox implementation by allowing any GeoJson as parameter and add support for feature and feature collection conversions. bboxPolygon has also been updated to allow for double[] which is the actual representation of bbox in turf vs the BoundingBox from geojson.