Feature.id() can be String and Number #1033
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions. |
|
This pull request has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions. |
|
This pull request has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions. |
tobrun
reviewed
Jan 8, 2020
| */ | ||
| @Nullable | ||
| public String id() { | ||
| public Object id() { |
There was a problem hiding this comment.
would be great to include as idAsString and idAsNumber facility methods (if the type doesn't match throw an exception).
|
Stale. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to GeoJson spec Feature.id can be String or Number.
This will be Semver-Major change as
id()has to returnObjectto support both String and Number.After #1025 lands, CarmenFeature.id() should be modified as well.
closes #914