Correct handling of a single element batch geocoding response #1160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
...coding/src/main/java/com/mapbox/api/geocoding/v5/SingleElementSafeCollectionTypeAdapter.java
Outdated
Show resolved
Hide resolved
...coding/src/main/java/com/mapbox/api/geocoding/v5/SingleElementSafeCollectionTypeAdapter.java
Outdated
Show resolved
Hide resolved
services-geocoding/src/test/java/com/mapbox/api/geocoding/v5/MapboxGeocodingTest.java
Show resolved
Hide resolved
cafesilencio
approved these changes
Jul 27, 2020
DzmitryFomchyn
force-pushed
the
df-json-parsing-fix
branch
from
f2109a1
to
3f9c4b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1119
Geocoding search service response has a different format depending on the query type
;, the service returns an array of results, represented as JSON array[{...}, {...}, ...]{...}This PR adds flexible JSON parsing that can handle both cases.