Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert experimental EV routing request and response parameters #1395

Merged
merged 1 commit into from
Apr 14, 2022

Conversation

RingerJK
Copy link
Contributor

@RingerJK RingerJK commented Apr 6, 2022

Revert experimental EV routing request and response parameters (e1b3f2f)

closes #1367

@RingerJK RingerJK requested a review from a team as a code owner April 6, 2022 13:18
@RingerJK RingerJK self-assigned this Apr 6, 2022
@RingerJK RingerJK force-pushed the kyv-experemental-ev-routes-revert branch 2 times, most recently from 387c5e0 to 9f9a294 Compare April 6, 2022 16:50
@RingerJK
Copy link
Contributor Author

RingerJK commented Apr 7, 2022

PR must be merged before the next mapbox-java and Nav SDK(2.4.0) GAs

@RingerJK RingerJK force-pushed the kyv-experemental-ev-routes-revert branch from 9f9a294 to 8e28389 Compare April 14, 2022 08:43
@codecov
Copy link

codecov bot commented Apr 14, 2022

Codecov Report

Merging #1395 (8e28389) into main (9ed67d7) will decrease coverage by 0.04%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1395      +/-   ##
============================================
- Coverage     75.23%   75.19%   -0.05%     
+ Complexity      920      883      -37     
============================================
  Files           125      124       -1     
  Lines          3957     3874      -83     
  Branches        645      597      -48     
============================================
- Hits           2977     2913      -64     
+ Misses          706      698       -8     
+ Partials        274      263      -11     
Impacted Files Coverage Δ
...x/api/directions/v5/models/DirectionsWaypoint.java 100.00% <ø> (ø)
...mapbox/api/directions/v5/models/LegAnnotation.java 100.00% <ø> (ø)
.../mapbox/api/directions/v5/models/RouteOptions.java 85.63% <50.00%> (+1.94%) ⬆️
...com/mapbox/api/directions/v5/MapboxDirections.java 88.88% <100.00%> (-1.90%) ⬇️

@RingerJK RingerJK enabled auto-merge (squash) April 14, 2022 08:47
@RingerJK RingerJK merged commit 085b02a into main Apr 14, 2022
@RingerJK RingerJK deleted the kyv-experemental-ev-routes-revert branch April 14, 2022 08:47
RingerJK added a commit that referenced this pull request Apr 14, 2022
korshaknn pushed a commit that referenced this pull request Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revert experimental EV changes before v6.4.0 stable release
2 participants