Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add RouteLeg#notifications #1542

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

add RouteLeg#notifications #1542

wants to merge 2 commits into from

Conversation

dzinad
Copy link
Contributor

@dzinad dzinad commented Apr 10, 2023

No description provided.

@dzinad dzinad requested a review from a team as a code owner April 10, 2023 10:35
@codecov
Copy link

codecov bot commented Apr 10, 2023

Codecov Report

Merging #1542 (1b31190) into main (d2848ac) will increase coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1542      +/-   ##
============================================
+ Coverage     77.36%   77.46%   +0.09%     
- Complexity      965      973       +8     
============================================
  Files           134      136       +2     
  Lines          4109     4126      +17     
  Branches        588      588              
============================================
+ Hits           3179     3196      +17     
  Misses          679      679              
  Partials        251      251              
Impacted Files Coverage Δ
.../com/mapbox/api/directions/v5/models/RouteLeg.java 100.00% <ø> (ø)
.../mapbox/api/directions/v5/models/Notification.java 100.00% <100.00%> (ø)
.../api/directions/v5/models/NotificationDetails.java 100.00% <100.00%> (ø)
.../mapbox/api/directions/v5/models/RouteOptions.java 95.23% <100.00%> (+0.02%) ⬆️
...com/mapbox/api/directions/v5/MapboxDirections.java 90.07% <100.00%> (+0.15%) ⬆️

@LukasPaczos
Copy link
Member

Flagging that backend API design is still in review so we shouldn't merge until that's finalized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants