Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add local aar and jar generation support #431

Merged
merged 3 commits into from
Apr 7, 2017

Conversation

Guardiola31337
Copy link
Contributor

@Guardiola31337 Guardiola31337 commented Apr 6, 2017

  • Added local aar and jar generation support
    In order to build locally (same procedure to both Android and Java libraries):
  1. Set IS_LOCAL_DEVELOPMENT gradle property to true (is false by default)
  2. $> gradlew uploadArchives
  3. aar or jar will be automatically installed in your Maven local repo folder (.m2/M2_HOME)
  4. Remember to add mavenLocal() in repositories{} (build.gradle) in the project in which you'd like to use Maven local repository
  • Fixed javadoc issue

👀 @zugaldia

…d java gradle config files respectively and fix javadoc issue
@zugaldia
Copy link
Member

zugaldia commented Apr 6, 2017

Bravo. This is a great solution.

Set IS_LOCAL_DEVELOPMENT gradle property to true (is false by default)

Per chat, let's explore how to set IS_LOCAL_DEVELOPMENT as an environment variable, with the plugin defaulting to true to make public releases more explicit. That way, we'd need to update our Bitrise rules to be like IS_LOCAL_DEVELOPMENT=false ./gradlew uploadArchives before uploading the artifacts.

@Guardiola31337
Copy link
Contributor Author

@zugaldia done 😉
Now if you want to install aars or jars in your Maven local repository you should define IS_LOCAL_DEVELOPMENT environment variable like this:

$> export IS_LOCAL_DEVELOPMENT=true

And $> export IS_LOCAL_DEVELOPMENT=false if you want same behavior as before. If IS_LOCAL_DEVELOPMENT is not exported also works as before.

@zugaldia
Copy link
Member

zugaldia commented Apr 6, 2017

Next, I want isLocalBuild to return true by default to make releases more explicit. Let's ticket that separately.

@Guardiola31337 Guardiola31337 force-pushed the pg-local-aar-gen-support branch 2 times, most recently from b4bac3c to 2939ebe Compare April 7, 2017 13:54
@Guardiola31337 Guardiola31337 merged commit cea7ce4 into master Apr 7, 2017
@Guardiola31337 Guardiola31337 deleted the pg-local-aar-gen-support branch April 7, 2017 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants