downgrade LOST to v1.1.1 #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guardiola31337
approved these changes
Jun 30, 2017
| @Override | ||
| public boolean isConnected() { | ||
| return lostApiClient.isConnected(); | ||
| } | ||
|
|
||
| /** | ||
| * Returns the Last known location is the location provider is connected and location permissions are granted. |
There was a problem hiding this comment.
Minor typo if instead of is.
tobrun
force-pushed
the
tvn-downgrade-lost
branch
from
bfa42bf
to
c48f520
Compare
tobrun
commented
Jun 30, 2017
| @@ -88,7 +87,7 @@ public void onConnectionFailed(@NonNull ConnectionResult connectionResult) { | |||
|
|
|||
| @Override | |||
| public Location getLastLocation() { | |||
| if (googleApiClient.isConnected() && PermissionsManager.areLocationPermissionsGranted(context.get())) { | |||
| if (googleApiClient.isConnected()) { | |||
There was a problem hiding this comment.
PermissionsManager.areLocationPermissionsGranted(context.get() is broken for pre Marshmallow devices
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copied from downstream ticket in mapbox/mapbox-gl-native#9394:
This PR requires a newer version of the SDK first to pass CI, excluding lost from the maps sdk makes the test application crash at startup.