Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added missing events #569

Merged
merged 2 commits into from Sep 20, 2017
Merged

added missing events #569

merged 2 commits into from Sep 20, 2017

Conversation

cammace
Copy link
Contributor

@cammace cammace commented Sep 20, 2017

No description provided.

@cammace cammace self-assigned this Sep 20, 2017
ericrwolfe
ericrwolfe suggested changes Sep 20, 2017
View reviewed changes
Copy link

@ericrwolfe ericrwolfe left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking back at this closely, everything we're adding as additional metadata to the cancel event should also be added to depart and arrive:

mapbox-java/mapbox/libandroid-telemetry/src/main/java/com/mapbox/services/android/telemetry/navigation/MapboxNavigationEvent.java

Lines 231 to 234 in 7703a7a

event.put(KEY_START_TIMESTAMP, TelemetryUtils.generateCreateDateFormatted(startTimestamp));
event.put(KEY_DISTANCE_COMPLETED, distanceCompleted);
event.put(KEY_DISTANCE_REMAINING, distanceRemaining);
event.put(KEY_DURATION_REMAINING, durationRemaining);

Maybe these could all just go into the getMetadata function?

@cammace cammace merged commit 0624cc5 into master Sep 20, 2017
@cammace cammace deleted the add-missing-depart-data branch September 20, 2017 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericrwolfe ericrwolfe ericrwolfe approved these changes

@Guardiola31337 Guardiola31337 Awaiting requested review from Guardiola31337

@danesfeder danesfeder Awaiting requested review from danesfeder

Assignees

@cammace cammace

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cammace @ericrwolfe