Look up the sdk download token at MAPBOX_DOWNLOADS_TOKEN too #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evil159
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that you are using
SDK_REGISTRY_TOKENas the property name for the secret token for downloading the mapbox sdk on android. Although you correctly state in the Readme that one should useSDK_REGISTRY_TOKENin thegradle.propertiesfile, I think it would be good to at least also look upMAPBOX_DOWNLOADS_TOKENin the gradle build file because that is the name used in the officiall install guide: https://docs.mapbox.com/android/maps/guides/install/.For people that come from older packages (e.g. mapbox_gl) or read the official install guide, it is unnecessarily confusing to use a different property name here. I would even suggest to change the Readme to use
MAPBOX_DOWNLOADS_TOKENto have that consistent (of course while still having a fallback toSDK_REGISTRY_TOKENfor users that already use the package). But I'll leave that decision to you.