Add geographical and screen coordinates to map interaction callbacks #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 4, 2024
evil159
force-pushed
the
rl/gesture_context
branch
from
5978d96
to
536b1ce
Compare
This was referenced Apr 4, 2024
pjleonard37
reviewed
Apr 10, 2024
| static MapContentGestureContext decode(Object result) { | ||
| result as List<Object?>; | ||
| return MapContentGestureContext( | ||
| touchPosition: ScreenCoordinate.decode(result[0]! as List<Object?>), |
There was a problem hiding this comment.
Is there a way we can avoid the forced !?
There was a problem hiding this comment.
This code is Pigeon-generated, it seems that the assumptions here, since the decoding and encoding is both done by Pigeon, they deem to be acceptable to force unwrap it.
Co-authored-by: Patrick Leonard <pjleonard37@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
Introduces
MapContentGestureContextcarrying touch point and projected map coordinate under the touch point of a gesture.Changes tap, long tap and move gesture callbacks to use
MapContentGestureContextinstead ofScreenCoordinate.What is the motivation and context behind this change?
ScreenCoordinateis not a correct type to represent geographical position. This is also a matter of ergonomics of providing both touch and geographical positions of a gesture.Addresses: https://mapbox.atlassian.net/browse/MAPSFLT-111, #81 and #190.
Pull request checklist: