Remove extraneous geo json source existence check (#1446)

* Remove unnecessary check before updating a geo json source * Update changelog
mapbox · Mar 29, 2023 · 2fc58ce · 2fc58ce
1 parent 2db1066
commit 2fc58ce
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 41 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,7 @@ Mapbox welcomes participation and contributions from everyone.
 
 ## main
 
+* Remove unnecessary check before updating a geo json source.
 * Remove deprecated `LocationManager.updateHeadingForCurrentDeviceOrientation()` method.
 * Remove deprecated `MapEvents.EventKind`.
 * Make NSNumber extension internal.

diff --git a/Sources/MapboxMaps/Style/StyleSourceManager.swift b/Sources/MapboxMaps/Style/StyleSourceManager.swift
@@ -91,11 +91,6 @@ internal final class StyleSourceManager: StyleSourceManagerProtocol {
     }
 
     internal func updateGeoJSONSource(withId id: String, geoJSON: GeoJSONObject, dataId: String? = nil) throws {
-        guard let sourceInfo = allSourceIdentifiers.first(where: { $0.id == id }),
-              sourceInfo.type == .geoJson else {
-            throw StyleError(message: "Source with id '\(id)' is not found or not a GeoJSONSource.")
-        }
-
         applyGeoJSON(data: geoJSON.sourceData, sourceId: id, dataId: dataId)
     }
 

diff --git a/Tests/MapboxMapsTests/Foundation/Style/StyleSourceManagerTests.swift b/Tests/MapboxMapsTests/Foundation/Style/StyleSourceManagerTests.swift
@@ -100,42 +100,6 @@ final class StyleSourceManagerTests: XCTestCase {
         XCTAssertEqual(styleManager.styleSourceExistsStub.invocations.count, 2)
     }
 
-    func testUpdateGeoJSONSourceThrowsForNotFoundSource() {
-        let id = String.randomASCII(withLength: 10)
-        let geoJSONObject = GeoJSONObject.featureCollection(FeatureCollection(features: []))
-
-        XCTAssertThrowsError(try sourceManager.updateGeoJSONSource(withId: id, geoJSON: geoJSONObject))
-    }
-
-    func testUpdateGeoJSONSourceWithDataIDThrowsForNotFoundSource() {
-        let id = "TestSourceID"
-        let geoJSONObject = GeoJSONObject.featureCollection(FeatureCollection(features: []))
-        let dataId = "TestdataId"
-
-        XCTAssertThrowsError(try sourceManager.updateGeoJSONSource(withId: id, geoJSON: geoJSONObject, dataId: dataId))
-    }
-
-    func testUpdateGeoJSONSourceThrowsForNotGeoJSONSource() {
-        let id = String.randomASCII(withLength: 10)
-        let geoJSONObject = GeoJSONObject.featureCollection(FeatureCollection(features: []))
-        let type = SourceType.raster
-        let info = StyleObjectInfo(id: id, type: type.rawValue)
-        styleManager.getStyleSourcesStub.defaultReturnValue = [info]
-
-        XCTAssertThrowsError(try sourceManager.updateGeoJSONSource(withId: id, geoJSON: geoJSONObject))
-    }
-
-    func testUpdateGeoJSONSourceWithDataIDThrowsForNotGeoJSONSource() {
-        let id = "TestSourceID"
-        let geoJSONObject = GeoJSONObject.featureCollection(FeatureCollection(features: []))
-        let dataId = "TestdataId"
-        let type = SourceType.raster
-        let info = StyleObjectInfo(id: id, type: type.rawValue)
-        styleManager.getStyleSourcesStub.defaultReturnValue = [info]
-
-        XCTAssertThrowsError(try sourceManager.updateGeoJSONSource(withId: id, geoJSON: geoJSONObject, dataId: dataId))
-    }
-
     func testUpdateGeoJSONSourceDispatchesParsingOnABackgroundThread() throws {
         let id = String.randomASCII(withLength: 10)
         let geoJSONObject = GeoJSONObject.featureCollection(FeatureCollection(features: []))