Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reset LocationProducer when changing provider #1172

Merged
merged 2 commits into from
Mar 4, 2022
Merged

Reset LocationProducer when changing provider #1172

merged 2 commits into from
Mar 4, 2022

Conversation

macdrevx
Copy link
Contributor

@macdrevx macdrevx commented Mar 4, 2022 •
edited

In #1145, we noticed that LocationProducer was not clearing its internal state when installing a new provider. This could result in delivery of locations with incorrect values.

Pull request checklist:

  • Write tests for all new functionality. If tests were not written, please explain why.
  • Describe the changes in this PR, especially public API changes.
  • Add a changelog entry to to bottom of the relevant section (typically the ## main heading near the top).
  • Review and agree to the Contributor License Agreement (CLA).

@macdrevx macdrevx requested a review from ZiZasaurus March 4, 2022 20:46
@macdrevx macdrevx enabled auto-merge (squash) March 4, 2022 20:51
@macdrevx macdrevx merged commit 7994b03 into main Mar 4, 2022
@macdrevx macdrevx deleted the fix/location-provider-updating branch March 4, 2022 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZiZasaurus ZiZasaurus ZiZasaurus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@macdrevx @ZiZasaurus