Add initial solution to moving target problem #1245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maios
approved these changes
Apr 5, 2022
| } | ||
|
|
||
| internal struct CameraOptionsComponent<T>: CameraOptionsComponentProtocol { | ||
| internal let keyPath: WritableKeyPath<CameraOptions, T?> |
There was a problem hiding this comment.
does it have to be a key path to an optional property of CameraOptions? I see that CameraOptions has everything as Optional now, but if in the future we decide to add new property that is non-optional then this will not work for those properties.
There was a problem hiding this comment.
It wouldn't have to be. Doing it this way allows value (on the next line) to be non-optional.
The *Options naming pattern in GL Native typically indicates a type where all of its fields are optional. You pass instances to a setter and non-nil fields are updated and any nil fields are not modified. Given that, it's probably unlikely that we'll add non-optional fields to CameraOptions in the future.
Sources/MapboxMaps/Viewport/Transitions/Default/DefaultViewportTransition.swift
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the DefaultViewportTransition to animate using SimpleCameraAnimator and update the animator's target camera dynamically during the animation. This approach results in arriving at exactly the right location at the end of the transition.
Before.-.Compressed.mp4
After.-.Compressed.mp4
The high-to-low and low-to-high animation spec providers are not yet tested. Those tests will be added in a subsequent PR.
Pull request checklist:
## mainheading near the top).